Azure create-infrastructure terraform warnings

[dtzar]

Issue

Many warnings happen from updates to the underlying azure terraform provider when running the create-infrastructure task to install/deploy PCF on Azure.
The provider version for template has an unnecessary warning.

Context

Annoying long scroll of warnings output and potentially breaking in future azure provider versions.

Expected result

No warnings.

Current result

Warning: azurerm_lb_rule.tcp-rule[0]: "location": [DEPRECATED] location is no longer used

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.template: version = "~> 1.0"

Steps to Reproduce

Run the create-infrastructure task.

Possible Fix

I have fixed these problems already, PR to come.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.