Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Remove replace statement in go.mod #766

Closed
antoninbas opened this issue Mar 10, 2020 · 3 comments
Closed

Remove replace statement in go.mod #766

antoninbas opened this issue Mar 10, 2020 · 3 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@antoninbas
Copy link
Contributor

Describe the problem/challenge you have
If a project implements an Octant plugin and imports both Octant and the K8s client-go, it is very easy to run into this "ambiguous import" issue: Azure/go-autorest#414.

Describe the solution you'd like
I am not sure why a replace directive was added to the go.mod in the first place, as this commit (849fd95) does not give an explanation, but maybe it is not required any more? I tries removing it from go.mod and running go mod tidy and it was able to pick up a more recent version of client-go which resolves the issue (thanks to this commit kubernetes/client-go@cca417f).

Anything else you would like to add:
I'm happy to open the corresponding PR if people are fine with this change.

@GuessWhoSamFoo GuessWhoSamFoo added the dependencies Pull requests that update a dependency file label Mar 10, 2020
@GuessWhoSamFoo
Copy link
Contributor

related #432

@wwitzel3
Copy link
Contributor

@bryanl is there any reason we can not remove the replace directive here?

@GuessWhoSamFoo
Copy link
Contributor

Closed via #931

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants