Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building without embedded libbacktrace #248

Open
jhance opened this issue May 7, 2022 · 3 comments
Open

Support building without embedded libbacktrace #248

jhance opened this issue May 7, 2022 · 3 comments

Comments

@jhance
Copy link

jhance commented May 7, 2022

Our python setup requires cross compiling, which isn't working because of ./configure running within setup.py. I have locally patched out the embedded libbacktrace and replaced it with link opts to a cross compiled libbacktrace. It would be nice to not need the patch; perhaps you would accept an patch to have an environment var that drops the libbacktrace embed stuff (and maybe append -lbacktrace)?

I would like to know whether you would accept such a patch before submitting a PR.

@mattip
Copy link
Contributor

mattip commented May 7, 2022

Do you mean you are using the libbacktrace sources in this repo to build a cross compiled version without configure? Could we adopt the direct call to the compiler/linker for all the builds without configure?

@jhance
Copy link
Author

jhance commented May 8, 2022

No, I actually built it from upstream source and linked it statically in with some flag (iirc --extra-link-objects or something). In my patch to vmprof-python I removed all traces of the libbacktrace embed from setup.py as I no longer need the embedded copy.

My specific use case is really just that I'm trying to target a newer glibc than is on the system (so ./configure bails when it realizes it can't run the binaries it compiles)

Not running configure is not really feasible in the general case (in this case am building libbacktrace with a preconfigured output for config.h and so forth to suit the cross compilation.

@mattip
Copy link
Contributor

mattip commented May 9, 2022

The change would be to have a configuration option to use the native libbacktrace ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants