Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository is not glued to Interface #35

Open
alirezaeiii opened this issue May 4, 2021 · 1 comment
Open

Repository is not glued to Interface #35

alirezaeiii opened this issue May 4, 2021 · 1 comment

Comments

@alirezaeiii
Copy link

Thank you for the great sample. I wonder why You do not have an interface for MarvelRepository or any other Repositories in your core module. You are following SOLID principles, and that is D is SOLID to follow dependency inversion.

High-level modules should not depend on low-level modules. Both should depend on abstractions (e.g., interfaces)

Using interfaces will also simplify unit testing.

Were there any specific reason that you did not use interface for Repository?

@Vaibhav2002
Copy link

@vmadalin can I make the interfaces for your repositories and rather than providing Repository implementation , provide The interface abstraction, which would make the code less tightly coupled, and will also make it easier for testing.
Can u assign this to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants