Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Prune tests/models/decoder_only/language/* tests #9940

Merged

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Nov 1, 2024

Signed-off-by: mgoin <michael@neuralmagic.com>
Copy link

github-actions bot commented Nov 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

mgoin added 2 commits November 4, 2024 15:31
Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: mgoin <michael@neuralmagic.com>
@mgoin mgoin marked this pull request as ready for review November 5, 2024 00:02
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 5, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for saving CI costs!

@DarkLight1337
Copy link
Member

It seems there are some failures in the tests though, please fix them.

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: mgoin <michael@neuralmagic.com>
@mergify mergify bot added the ci/build label Nov 5, 2024
@mgoin mgoin merged commit 0246246 into vllm-project:main Nov 5, 2024
79 checks passed
@mgoin mgoin deleted the prune-decoder-only-language-tests branch November 5, 2024 21:02
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
)

Signed-off-by: mgoin <michael@neuralmagic.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
)

Signed-off-by: mgoin <michael@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants