Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Support quantization of Qwen2VisionTransformer for Qwen2-VL #9817

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Oct 29, 2024

Relies on #9812

Allows us to support quantization of the vision encoder for Qwen2-VL, where before we could only quantize the language model

Tested with

  • nm-testing/Qwen2-VL-7B-Instruct-FP8-dynamic (only Qwen2Model quantized)
  • nm-testing/Qwen2-VL-7B-Instruct-FP8-dynamic-all (Qwen2Model and Qwen2VisionTransformer quantized, just not lm_head)

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support for quantization for this model!

@mgoin mgoin requested a review from DarkLight1337 October 30, 2024 01:53
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 30, 2024
@youkaichao youkaichao merged commit d087bf8 into vllm-project:main Oct 31, 2024
67 of 70 checks passed
@youkaichao youkaichao deleted the qwen2vl-quant-vision branch October 31, 2024 05:41
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
…9817)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Linkun Chen <github+anyscale@lkchen.net>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
…9817)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
…9817)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
…9817)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
…9817)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
sergeykochetkov pushed a commit to sergeykochetkov/vllm_spec_decoding that referenced this pull request Dec 27, 2024
…9817)

Signed-off-by: mgoin <michael@neuralmagic.com>
Signed-off-by: s.kochetkov <s.m.kochetkov@tcsbank.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants