Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Add the DCO to CONTRIBUTING.md #9803

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[Doc] Add the DCO to CONTRIBUTING.md #9803

merged 2 commits into from
Oct 30, 2024

Conversation

russellb
Copy link
Collaborator

PRs to vLLM now require a Signed-off-by header as an acknowledgement
of the DCO. Add the DCO to the repo and update CONTRIBUTING.md with a
pointer to it.

While in there, add a LICENSE link to the contributing doc as well.

Signed-off-by: Russell Bryant rbryant@redhat.com

@russellb
[Doc] Add the DCO to CONTRIBUTING.md
5b2de36 
PRs to vLLM now require a `Signed-off-by` header as an acknowledgement
of the DCO. Add the DCO to the repo and update CONTRIBUTING.md with a
pointer to it.

While in there, add a LICENSE link to the contributing doc as well.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Oct 29, 2024
DarkLight1337
DarkLight1337 reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this - various PR authors have already expressed confusion over the DCO bot, so this should help clear that up!

CONTRIBUTING.md Outdated Show resolved Hide resolved
@njhill
Copy link
Member

njhill commented Oct 29, 2024

Thanks @russellb this was very much needed!

@mgoin @DarkLight1337
Update CONTRIBUTING.md
5b9ae1c 
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 29, 2024
@mgoin mgoin enabled auto-merge (squash) October 29, 2024 22:57
@mgoin mgoin merged commit 7b0365e into vllm-project:main Oct 30, 2024
50 of 51 checks passed
rasmith pushed a commit to rasmith/vllm that referenced this pull request Oct 30, 2024
@russellb @mgoin
@DarkLight1337 @rasmith
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
09078e1 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Randall Smith <Randall.Smith@amd.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@russellb @mgoin
@DarkLight1337 @NickLucche
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
d827697 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
@russellb @mgoin
@DarkLight1337 @NickLucche
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
daebf9a 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: NickLucche <nlucches@redhat.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@russellb @mgoin @DarkLight1337
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
53310b2 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
@russellb @mgoin @DarkLight1337
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
567bd72 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Linkun Chen <github+anyscale@lkchen.net>
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
@russellb @mgoin
@DarkLight1337 @hissu-hyvarinen
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
04a4bbd 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@russellb @mgoin
@DarkLight1337 @JC1DA
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
2337338 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@russellb @mgoin
@DarkLight1337 @sumitd2
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
0d5a757 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@russellb @mgoin @DarkLight1337
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
e90a94d 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@russellb @mgoin
@DarkLight1337 @mfournioux
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
9f30efd 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@russellb @mgoin
@DarkLight1337 @tlrmchlsmth
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
caaffe0 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@russellb @mgoin @DarkLight1337
[Doc] Add the DCO to CONTRIBUTING.md (vllm-project#9803)
4f210be 
Signed-off-by: Russell Bryant <rbryant@redhat.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Cyrus Leung <cyrus.tl.leung@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 left review comments

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@russellb @njhill @mgoin @DarkLight1337