Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Reduce frequency of client cancellation checking #7959

Merged
merged 3 commits into from
Oct 21, 2024

Conversation

njhill
Copy link
Member

@njhill njhill commented Aug 28, 2024

The api server logic currently checks for client http connection disconnection for each request between every generated token. We can reduce the cost associated with this by limiting the checks to at most once per second.

With llama-3.2-1B, A100 tp=1, --num-scheduler-steps=8:

stream multistep-stream req/sec before this PR req/sec after this PR
false n/a 95 95
true false 92 94
true true 42 67
python benchmarks/benchmark_serving.py \
    --backend vllm \
    --model meta-llama/Llama-3.2-1B \
    --dataset-name sharegpt \
    --dataset-path ShareGPT_V3_unfiltered_cleaned_split.json \
    --port 9999 \
    --save-result \
    --result-dir results \
    --result-filename test.json \
    --num-prompts 2000 \
    --request-rate 200 \
    --seed 42

@vllm-project vllm-project deleted a comment from github-actions bot Sep 4, 2024
The api server logic currently checks for client http connection disconnection for each request between every generated token. We can reduce the cost associated with this by limiting the checks to at most once per second.
@njhill njhill force-pushed the less-cancel-check branch from ea4a656 to 7ab125a Compare October 18, 2024 04:02
@njhill njhill marked this pull request as ready for review October 18, 2024 04:03
@njhill njhill added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 18, 2024
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit about comment placement

@njhill njhill merged commit 9d9186b into vllm-project:main Oct 21, 2024
55 checks passed
@njhill njhill deleted the less-cancel-check branch October 21, 2024 20:28
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
…ject#7959)

Signed-off-by: Erkin Sagiroglu <erkin@infra-aipipeline-1-at1-prox-prod-a.ipa.corp.telnyx.com>
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
…ject#7959)

Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
…ject#7959)

Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants