-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Reduce frequency of client cancellation checking #7959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The api server logic currently checks for client http connection disconnection for each request between every generated token. We can reduce the cost associated with this by limiting the checks to at most once per second.
ea4a656
to
7ab125a
Compare
mgoin
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one nit about comment placement
charlifu
pushed a commit
to charlifu/vllm
that referenced
this pull request
Oct 23, 2024
…ject#7959) Signed-off-by: charlifu <charlifu@amd.com>
vrdn-23
pushed a commit
to vrdn-23/vllm
that referenced
this pull request
Oct 23, 2024
…ject#7959) Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…ject#7959) Signed-off-by: Alvant <alvasian@yandex.ru>
MErkinSag
pushed a commit
to MErkinSag/vllm
that referenced
this pull request
Oct 26, 2024
…ject#7959) Signed-off-by: Erkin Sagiroglu <erkin@infra-aipipeline-1-at1-prox-prod-a.ipa.corp.telnyx.com>
garg-amit
pushed a commit
to garg-amit/vllm
that referenced
this pull request
Oct 28, 2024
…ject#7959) Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
FerdinandZhong
pushed a commit
to FerdinandZhong/vllm
that referenced
this pull request
Oct 29, 2024
…ject#7959) Signed-off-by: qishuai <ferdinandzhong@gmail.com>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
…ject#7959) Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu
pushed a commit
to KuntaiDu/vllm
that referenced
this pull request
Nov 20, 2024
mfournioux
pushed a commit
to mfournioux/vllm
that referenced
this pull request
Nov 20, 2024
…ject#7959) Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Nov 23, 2024
…ject#7959) Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The api server logic currently checks for client http connection disconnection for each request between every generated token. We can reduce the cost associated with this by limiting the checks to at most once per second.
With llama-3.2-1B, A100 tp=1,
--num-scheduler-steps=8
: