Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] EXAONE 3.0 model support #7942

Closed
wants to merge 10 commits into from
Closed

Conversation

Deepfocused
Copy link

@Deepfocused Deepfocused commented Aug 28, 2024

Hello, I am deepfocused from the AI ​​engineering Team at LG CNS.
we want to integrate the recently opened model EXAONE-3.0-7.8B-Instruct model into vLLM.

Previously, we have been servicing models such as EXAONE v1, v2, etc. to our customers as vLLM through the vLLM + EXAONE build. Unlike these previous models, EXAONE 3.0 was released as an open model, so we are requesting integration.

Paper: [EXAONE 3.0 7.8B Instruction Tuned Language Model](https://huggingface.co/papers/2408.03541)
HuggingFace: [LGAI-EXAONE/EXAONE-3.0-7.8B-Instruct](https://huggingface.co/LGAI-EXAONE/EXAONE-3.0-7.8B-Instruct)
Github: [LG-AI-EXAONE/EXAONE-3.0](https://github.com/LG-AI-EXAONE/EXAONE-3.0)

It was written based on the llama.py model,
To run the EXAONE 3.0 model,
For offline execution,

import os
os.environ['HF_TOKEN'] = "your key"
llm = LLM(model="EXAONE-3.0-7.8B-Instruct", 
           ...)

For vllm server execution,

export HF_TOKEN="your key"
vllm serve LGAI-EXAONE/EXAONE-3.0-7.8B-Instruct 

❗ Added exaone configuration file to vllm/transformers_utils to allow omitting trust_remote_code or --trust-remote-code at runtime.
Once Exaone is integrated into the transformer library, the above tasks will no longer be necessary ~

thank you.

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Deepfocused Deepfocused changed the title [Model] EXAONE 3.0 model support - reupdate [Model] EXAONE 3.0 model support Aug 28, 2024
@Deepfocused
Copy link
Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 28, 2024
Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work locally for me and seems reasonable, thanks!

>>> from vllm import LLM
>>> model = LLM("LGAI-EXAONE/EXAONE-3.0-7.8B-Instruct")
>>> model.chat([{"role":"user","content":"Hello!"}])
Processed prompts: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00,  4.86it/s, est. speed input: 102.15 toks/s, output: 77.82 toks/s]
[RequestOutput(request_id=1, prompt='[|system|][|endofturn|]\n[|user|]Hello!\n[|assistant|]', prompt_token_ids=[420, 453, 47982, 453, 422, 361, 560, 420, 453, 14719, 453, 422, 33381, 362, 560, 420, 453, 1167, 8659, 453, 422], encoder_prompt=None, encoder_prompt_token_ids=None, prompt_logprobs=None, outputs=[CompletionOutput(index=0, text='Hello! How can I help you today? If you have any questions or need', token_ids=array('l', [33381, 362, 2417, 1093, 768, 2347, 904, 4963, 392, 2386, 904, 1072, 1491, 5344, 913, 1788]), cumulative_logprob=None, logprobs=None, finish_reason=length, stop_reason=None)], finished=True, metrics=RequestMetrics(arrival_time=1724860809.4073465, last_token_time=1724860809.4073465, first_scheduled_time=1724860809.408349, first_token_time=1724860809.4238176, time_in_queue=0.0010025501251220703, finished_time=1724860809.6029909, scheduler_time=0.000975252129137516, model_forward_time=None, model_execute_time=None), lora_request=None)]

Also ran an eval on gsm8k

lm_eval --model vllm --model_args pretrained=LGAI-EXAONE/EXAONE-3.0-7.8B-Instruct,max_model_len=4096,enable_chunked_prefill=True --tasks gsm8k --batch_size auto
vllm (pretrained=LGAI-EXAONE/EXAONE-3.0-7.8B-Instruct,max_model_len=4096,enable_chunked_prefill=True), gen_kwargs: (None), limit: None, num_fewshot: None, batch_size: auto
|Tasks|Version|     Filter     |n-shot|  Metric   |   |Value |   |Stderr|
|-----|------:|----------------|-----:|-----------|---|-----:|---|-----:|
|gsm8k|      3|flexible-extract|     5|exact_match|↑  |0.8044|±  |0.0109|
|     |       |strict-match    |     5|exact_match|↑  |0.8021|±  |0.0110|

@Deepfocused
Copy link
Author

Deepfocused commented Aug 28, 2024

The existing unopened EXAONE v1 and EXAONE v2 models had a different structure from llama, but the newly released EXAONE v3 model has the same structure as llama, but there are differences in variable names. Therefore, in order to run EXAONE v3 on vLLM, several variable names and weight names had to be changed in the llama structure.

For example,
down_proj -> self.c_proj
gate_proj -> c_fc_0
up_proj" -> c_fc_1
config.rms_norm_eps -> config.layer_norm_epsilon
There are a few more. (Refer to the code)

There were variable changes such as these.
EXAONE 3.0 seems to focus more on data and training methods based on the llama structure rather than changing the model structure.

Thank you~

@Deepfocused Deepfocused requested a review from mgoin August 28, 2024 17:09
@simon-mo
Copy link
Collaborator

Merged #7819

@simon-mo simon-mo closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants