Skip to content

Specify python package dependencies in requirements.txt #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 7, 2023
Merged

Conversation

WoosukKwon
Copy link
Collaborator

Closes #56

This PR specifies the python package dependencies in requirements.txt. The file will be parsed by setup.py.

Why not directly specify them in setup.py?

For those who build CacheFlow from source, the dependencies (or at least pytorch) should be installed BEFORE executing pip install .. This is because we use pytorch (and ninja) to build our custom operators. Having requirements.txt allows those people to easily install the dependencies before build.

@WoosukKwon WoosukKwon requested a review from zhuohan123 May 6, 2023 07:59
@WoosukKwon
Copy link
Collaborator Author

For people who use pre-built wheels, we should make sure that a single pip install command completes the whole setup process. This is not done in this PR.

@WoosukKwon WoosukKwon merged commit 7addca5 into main May 7, 2023
@WoosukKwon WoosukKwon deleted the setup branch May 7, 2023 23:30
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
dllehr-amd pushed a commit to dllehr-amd/vllm that referenced this pull request Jul 22, 2024
* Initializing hipblaslt workspace for fp8 gemms

* make workspace size configurable

* assign default value for worksapce pointer

* fix clang-format

* fix clang-format

---------

Co-authored-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
yma11 pushed a commit to yma11/vllm that referenced this pull request Oct 17, 2024
yma11 pushed a commit to yma11/vllm that referenced this pull request Oct 30, 2024
Signed-off-by: YiSheng5 <syhm@mail.ustc.edu.cn>
wuhuikx pushed a commit to wuhuikx/vllm that referenced this pull request Mar 27, 2025
### What this PR does / why we need it?
Refeactor installation doc

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
CI, preview

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dependencies in setup.py
1 participant