Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Install Buildkite test suite analysis #7667

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Aug 19, 2024

No description provided.

p
Signed-off-by: kevin <kevin@anyscale.com>
@khluu khluu changed the title [ci] Install BK test suite analysis [ci] Install Buildkite test suite analysis Aug 19, 2024
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice i already want to do this.

@khluu
Copy link
Collaborator Author

khluu commented Aug 19, 2024

nice i already want to do this.

yep we have way too many flaky and broken tests from time to time ...

@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 20, 2024
@khluu khluu merged commit 0df7ec0 into vllm-project:main Aug 20, 2024
74 of 78 checks passed
zifeitong pushed a commit to zifeitong/vllm that referenced this pull request Aug 20, 2024
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
omrishiv pushed a commit to omrishiv/vllm that referenced this pull request Aug 26, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: kevin <kevin@anyscale.com>
Signed-off-by: Alvant <alvasian@yandex.ru>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: kevin <kevin@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants