Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc]Fix BitAndBytes exception messages #7626

Merged
merged 3 commits into from
Aug 17, 2024
Merged

[Misc]Fix BitAndBytes exception messages #7626

merged 3 commits into from
Aug 17, 2024
+2 −2

Conversation

jeejeelee
Copy link
Contributor

@jeejeelee jeejeelee commented Aug 17, 2024 •
edited
Loading

FIX #7624
ping @mgoin

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

mgoin
mgoin approved these changes Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the quick fix for the issue! Not sure if the exception is a function of the model or how it was quantized/saved by bitsandbytes though

vllm/model_executor/model_loader/loader.py Show resolved Hide resolved
@jeejeelee jeejeelee requested a review from mgoin August 17, 2024 16:56
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 17, 2024
@youkaichao youkaichao merged commit 1ef13cf into vllm-project:main Aug 17, 2024
56 of 58 checks passed
zifeitong pushed a commit to zifeitong/vllm that referenced this pull request Aug 20, 2024
@jeejeelee @zifeitong
[Misc]Fix BitAndBytes exception messages (vllm-project#7626)
e8e55ab
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
@jeejeelee @fialhocoelho
[Misc]Fix BitAndBytes exception messages (vllm-project#7626)
fb42bd8
omrishiv pushed a commit to omrishiv/vllm that referenced this pull request Aug 26, 2024
@jeejeelee @omrishiv
[Misc]Fix BitAndBytes exception messages (vllm-project#7626)
6737fba
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@jeejeelee @Alvant
[Misc]Fix BitAndBytes exception messages (vllm-project#7626)
d479ba2 
Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin Awaiting requested review from mgoin

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: Model BitsAndBytesModelLoader does not support BitsAndBytes quantization yet
3 participants
@jeejeelee @mgoin @youkaichao