-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Add UltravoxModel and UltravoxConfig #7615
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
@petersalas Very exciting! Is this PR ready for review? Also FYI I'm doing some refactoring in #7530 so please update your PR after that gets merged. Thanks! |
3054191
to
8d450c9
Compare
@ywang96 Thanks for the heads up! I updated the PR with the latest changes -- this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and I left first round of review!
I didn't see a correctness test added to this PR, and typically we don't require a correctness test if the model contribution is directly from the model vendor, but I assume you have already tested the implementation.
Finally, could you add example usage under examples
directory for both offline and online inference? (feel free to modify openai_vision_api_client.py
)
Thank you!
@petersalas Overall I think this PR is in a good shape! I'll give this PR a go with some manual testing just as a validation as well as leaving @DarkLight1337 with some time in case he wants to take a look too. Otherwise if everything goes well and all test pass, we should be able to merge this PR this week! |
Amazing, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've run the examples of this model with TP=1 and TP=2 (and it's working really well!) and confirmed test_ultravox.py
passed in my dev environment.
Left some final comments, otherwise LGTM! Thank you and fixie.ai for contributing this model to vLLM!
@ywang96 Let's apply my suggestion in this PR. |
Actually I don't have access to push changes to this branch... |
@petersalas per discussion above - could you also push a change to line 189 in |
@petersalas Looks like moving the cached tokenizer from
|
Fixed, sorry about that! |
Signed-off-by: Alvant <alvasian@yandex.ru>
Signed-off-by: Alvant <alvasian@yandex.ru>
This adds support for the Ultravox speech model and changes
tests/entrypoints/openai/test_audio.py
to use Ultravox instead of a mocked audio model.BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!