-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Model] Add Support for GPTQ Fused MOE #6502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well. To run full CI, you can do one of these:
🚀 |
6e75b4f
to
ae47d9b
Compare
@robertgshaw2-neuralmagic Sorry to bother you, do you have any suggestions/comments for this pr which will guide me to modify it further! |
Any problem on a800-80g, please refer to this PR. |
@izhuhaoran Hi, When I reason about the qwen-moe-gptq-int4 model, it always prompts triton.runtime.errors.OutOfResources: out of resource: shared memory, Error, how to solve it |
We calibrate the triton kernel configs for A100 and H800 and for qwen2_moe model using https://github.com/vllm-project/vllm/blob/main/benchmarks/kernels/benchmark_moe.py. To avoid out of shared memory error, you could try calibrate your own config. |
Thank you. I'll try |
cd5a584
to
04813f2
Compare
Is this PR currently in a state of moving forward? @robertgshaw2-neuralmagic @izhuhaoran |
Yes, still progressing. BTW, I just updated the kernel implementation, looking forward to any comments from reviewers! |
Thank you very much, I'm glad to see this PR is still moving forward. BTW, @mgoin @robertgshaw2-neuralmagic I'd like to know your considerations on this PR. There have indeed been some similar efforts recently. |
I noticed that the script located at /benchmarks/kernels/benchmark_moe.py doesn't currently support qwen-moe-gptq-int4 model. I would greatly appreciate it if you could share how you use this script to generate configuration files, such as E=64,N=1280,device_name=NVIDIA_A100-SXM4-80GB,dtype=a16w4.json. Thank you for your assistance! |
Bug ReportI would like to bring to your attention a potential bug in the code. It seems that the line I observed that my inference results were incorrect, and upon further investigation, I found that when the config file is not located in |
@izhuhaoran @jeejeelee Sorry for the lack of review! There is a PR porting the Marlin kernel to grouped gemm (#7527) so we should have GPTQ Fused MoE support for most models with this. I think we could consider this kernel separately (especially if it supports more quantization configs), but I would like to see some performance comparison |
|
Thanks a lot for your feedback @jeejeelee ! |
Since the existing Marlin kernels are consistently faster, I'm going to close this. |
This PR adds support for GPTQ Fused Mixture-of-Experts (MoE) ,and test passed for Qwen2-57B-A14B-Instruct-GPTQ-Int4 and Qwen1.5-MoE-A2.7B-Chat-GPTQ-Int4 on A100/A800 GPUs
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!