[ci] Fix wording for GH bot #6398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Full CI run is still required to merge this PR so please make sure that you run full CI before merging or if you need more test signals. To run full CI, you can do one of these:
🚀 |
zifeitong
reviewed
Jul 12, 2024
| @@ -15,7 +15,7 @@ jobs: | |||
| owner: context.repo.owner, | |||
| repo: context.repo.repo, | |||
| issue_number: context.issue.number, | |||
| body: '👋 Hi! Thank you for contributing to the vLLM project.\n Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger `fastcheck` CI to run, which consists only a small and essential subset of tests to quickly catch small errors.\n\nFull CI run is still required to merge this PR so please make sure that you run full CI before merging or if you need more test signals.\n\n To run full CI, you can do one of these:\n- Add `ready` label to the PR\n- Comment `/ready` on the PR\n- Enable auto-merge.\n\n🚀' | |||
| body: '👋 Hi! Thank you for contributing to the vLLM project.\n Just a reminder: PRs would not trigger full CI run by default. Instead, it would only trigger `fastcheck` CI to run, which consists only a small and essential subset of tests to quickly catch errors with the flexibility to run extra individual tests on top (you can do this by unblocking test steps in the Buildkite run). \n\nFull CI run is still required to merge this PR so once the PR is ready to go, please make sure to run it. If you need all test signals in between PR commits, you can trigger full CI as well.\n\n To run full CI, you can do one of these:\n- Add `ready` label to the PR\n- Comment `/ready` on the PR\n- Enable auto-merge.\n\n🚀' | |||
There was a problem hiding this comment.
Add
readylabel to the PR\n- Comment/readyon the PR\n- Enable auto-merge
For people without write permission, /ready comment is the only available option. I think it's better to make it clear or at least move it to the first.
There was a problem hiding this comment.
ya great idea! Updated
simon-mo
approved these changes
Jul 12, 2024
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jul 17, 2024
Signed-off-by: kevin <kevin@anyscale.com>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Signed-off-by: kevin <kevin@anyscale.com>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: kevin <kevin@anyscale.com> Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.