Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Fix Buildkite agent path #5392

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Jun 10, 2024

c5602f0 didn't get the path of buildkite-agent when checking whether the path exists. Calling buildkite-agent by itself still works. This PR is to have it check the full path of buildkite agent binary as /usr/bin/buildkite-agent .
Passing build with benchmark results in the build is here: https://buildkite.com/vllm/ci-aws/builds/879

khluu added 3 commits June 10, 2024 18:57
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
p
Signed-off-by: kevin <kevin@anyscale.com>
@khluu khluu requested a review from simon-mo June 10, 2024 21:00
@khluu
Copy link
Collaborator Author

khluu commented Jun 10, 2024

ci-aws build failed because I cancelled it (didn't want to waste resources on running full build with all tests). The build that tests the changes is linked in the description.

@simon-mo simon-mo merged commit 76477a9 into vllm-project:main Jun 11, 2024
50 of 65 checks passed
tjohnson31415 added a commit to tjohnson31415/vllm that referenced this pull request Jun 11, 2024
* upstream/main: (126 commits)
  [Bugfix][Frontend] Cleanup "fix chat logprobs" (vllm-project#5026)
  [Bugfix] OpenAI entrypoint limits logprobs while ignoring server defined --max-logprobs (vllm-project#5312)
  [Misc] Various simplifications and typing fixes (vllm-project#5368)
  [ci] Fix Buildkite agent path (vllm-project#5392)
  [Doc] Add documentation for FP8 W8A8 (vllm-project#5388)
  Bump version to v0.5.0 (vllm-project#5384)
  [Docs] Alphabetically sort sponsors (vllm-project#5386)
  [Docs] Add Docs on Limitations of VLM Support (vllm-project#5383)
  [ci] Mount buildkite agent on Docker container to upload benchmark results (vllm-project#5330)
  [ci] Use small_cpu_queue for doc build (vllm-project#5331)
  [Bugfix] Fix LLaVA-NeXT (vllm-project#5380)
  [Feature][Frontend]:  Continued `stream_options` implementation also in CompletionRequest (vllm-project#5319)
  [Model] Initial support for LLaVA-NeXT (vllm-project#4199)
  [Misc] Improve error message when LoRA parsing fails (vllm-project#5194)
  [misc][typo] fix typo (vllm-project#5372)
  [Frontend][Misc] Enforce Pixel Values as Input Type for VLMs in API Server (vllm-project#5374)
  [Misc] Update to comply with the new `compressed-tensors` config (vllm-project#5350)
  [Bugfix] Fix KeyError: 1 When Using LoRA adapters (vllm-project#5164)
  [Kernel][Misc] Use TORCH_LIBRARY instead of PYBIND11_MODULE for custom ops (vllm-project#5047)
  [mis][ci/test] fix flaky test in test_sharded_state_loader.py (vllm-project#5361)
  ...
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 12, 2024
Signed-off-by: kevin <kevin@anyscale.com>
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
Signed-off-by: kevin <kevin@anyscale.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
Signed-off-by: kevin <kevin@anyscale.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
Signed-off-by: kevin <kevin@anyscale.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Signed-off-by: kevin <kevin@anyscale.com>
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Signed-off-by: kevin <kevin@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants