-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix Mistral v0.3 Weight Loading #5005
Merged
robertgshaw2-neuralmagic
merged 17 commits into
vllm-project:main
from
neuralmagic:mistral-v0.3-fix
May 24, 2024
Merged
[Bugfix] Fix Mistral v0.3 Weight Loading #5005
robertgshaw2-neuralmagic
merged 17 commits into
vllm-project:main
from
neuralmagic:mistral-v0.3-fix
May 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoin
reviewed
May 23, 2024
Closed
6 tasks
comaniac
approved these changes
May 23, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
Yard1
approved these changes
May 23, 2024
simon-mo
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamp to unblock merge
update to re-run CI
Does this fix #4989 by any chance? |
Yep |
Hi, in what vllm version is the KeyError fixed. vllm-0.4.2 still returns the error with Mistral-7B-Instruct-v0.3 |
@jmlb The fix probably hasn't been published to PyPI yet. You can install vLLM's main branch directly with pip install git+https://github.com/vllm-project/vllm.git@main |
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
May 31, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
robertgshaw2-neuralmagic
added a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jul 14, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FILL IN THE PR DESCRIPTION HERE
Mistral v0.3 has multiple copies of the safetensors file on hf hub
considated.safetensors
<< which has all the weights w/ a different state dictmodel.0001-of-0004.safetensors
<< which has the shard of the weights w/ the llama state dictThis PR adds support for downloading the
model.safetensors.index.json
file. We then look into this file to determine which files to use, skipping any files that are not found in the index.Validated this works will
mistral-v0.3
,llama-3
(which has an index, but no consolidated),tinyllama
(which has no index) and withHF_HUB_OFFLINE=1
.This PR still has the issue that it will download all weights as opposed to just the shards. We should see if we can fix this in a follow up PR. We currently rely on
allow_patterns="*.safetensors"
insnapshot_download
today so this will be trickyValidated with:
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!