Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix Mistral v0.3 Weight Loading #5005

Merged

Conversation

robertgshaw2-neuralmagic
Copy link
Collaborator

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic commented May 23, 2024

FILL IN THE PR DESCRIPTION HERE

Mistral v0.3 has multiple copies of the safetensors file on hf hub

  • considated.safetensors << which has all the weights w/ a different state dict
  • model.0001-of-0004.safetensors << which has the shard of the weights w/ the llama state dict

This PR adds support for downloading the model.safetensors.index.json file. We then look into this file to determine which files to use, skipping any files that are not found in the index.

Validated this works will mistral-v0.3, llama-3 (which has an index, but no consolidated), tinyllama (which has no index) and with HF_HUB_OFFLINE=1.

This PR still has the issue that it will download all weights as opposed to just the shards. We should see if we can fix this in a follow up PR. We currently rely on allow_patterns="*.safetensors" in snapshot_download today so this will be tricky

Validated with:

  • mistral v0.3 (index.json, sharded, consolidated.safetensors
  • tinyllama (no index.json)
  • llama (index.json, but no consolidated.safetensors)
  • HF_HUB_OFFLINE=0
  • HF_HUB_OFFLINE=1

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic marked this pull request as ready for review May 23, 2024 10:38
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamp to unblock merge

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic enabled auto-merge (squash) May 23, 2024 17:49
@ShukantPal
Copy link
Contributor

Does this fix #4989 by any chance?

@robertgshaw2-neuralmagic
Copy link
Collaborator Author

Yep

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic merged commit 9197709 into vllm-project:main May 24, 2024
63 checks passed
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic deleted the mistral-v0.3-fix branch May 24, 2024 12:28
@jmlb
Copy link

jmlb commented May 25, 2024

Hi, in what vllm version is the KeyError fixed. vllm-0.4.2 still returns the error with Mistral-7B-Instruct-v0.3

@ShukantPal
Copy link
Contributor

@jmlb The fix probably hasn't been published to PyPI yet. You can install vLLM's main branch directly with

pip install git+https://github.com/vllm-project/vllm.git@main

dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request May 31, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
robertgshaw2-neuralmagic added a commit to neuralmagic/nm-vllm that referenced this pull request Jul 14, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants