-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] Support OpenAI batch file format #4794
[Frontend] Support OpenAI batch file format #4794
Conversation
@@ -101,7 +101,7 @@ async def show_version(): | |||
async def create_chat_completion(request: ChatCompletionRequest, | |||
raw_request: Request): | |||
generator = await openai_serving_chat.create_chat_completion( | |||
request, raw_request) | |||
request, raw_request.is_disconnected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if this PR did not touch this file
method: str | ||
|
||
# The OpenAI API relative URL to be used for the request. Currently | ||
# /v1/chat/completions is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we cannot support /v1/embeddings
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ This could be done in a follow up PR ]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can support the other 2 endpoints in follow ups.
Yes I agree, I tried to use the wording "batch file format" everywhere but when writing the documentation I can be even more explicit. I alluded to it in the ticket (and I think you noticed it too on slack), but the actual openai api is tightly coupled to its file concept and opens up a whole can of worms around life cycle management/long lived state.
Updated to maintain backwards compatibility in the signature, but let me know if you have something specific in mind.
Yup, agreed |
This looks great. Can you just add a short example of |
|
||
The OpenAI batch file format consists of a series of json objects on new lines. | ||
|
||
[See here for an example file.](https://github.com/vllm-project/vllm/blob/main/examples/openai_example_batch.jsonl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These examples links point to master, so they don't work now, but should work once merged.
Example/docs are in. Let me know what you think. |
LGTM. Waiting for the CI to pass |
Thanks for the good work here |
openi_example_batch.jsonl -> openai_example_batch.jsonl ? |
🤦yes, thanks for catching that. |
@wuisawesome ping me on slack and ill merge it |
I think we're good here, Sang merged it already |
Co-authored-by: Robert Shaw <114415538+robertgshaw2-neuralmagic@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-neuralmagic@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-neuralmagic@users.noreply.github.com>
This PR adds basic support for the OpenAI batch file format (for chat endpoints).
The following help page summarizes the usage options:
Assuming the following file exists:
The program is run as
python -m vllm.entrypoints.openai.run_batch -i ../batch.jsonl -o ../results.jsonl --model meta-llama/Meta-Llama-3-8B-Instruct
(this produces the typical logging from the async engine, which I've omitted).Finally, the resulting file produced is:
FIX #4777
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!