[Bugfix] Fix call to init_logger in openai server #4765
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running the OpenAI entrypoint, all logs coming from this file will not be shown.
This is because the call to
init_logger
at the top of the file uses the__name__
global variable, and it's value is__main__
since this is the main file, which causes theinit_logger
function to return a logger with default configuration instead of the one configured in the logger file.To solve this I changed the call to
init_logger
to pass a string instead of__name__
, but another possible and potentially more elegant solution would be changing theinit_logger
function so the logger name is optional, and omitting it in the OpenAI entrypoint: