Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Bump transformers to latest version #4176

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

njhill
Copy link
Member

@njhill njhill commented Apr 18, 2024

There are small changes to the tokenizers library related to supporting the converted llama 3 titkoken tokenizer.

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@njhill njhill force-pushed the transformers-4.40 branch from f939c21 to 83e74ba Compare April 18, 2024 17:56
@zhuohan123
Copy link
Member

Saw this error in CI. Is the version correct?

ERROR: No matching distribution found for tokenizers>=1.19.1

@njhill
Copy link
Member Author

njhill commented Apr 18, 2024

@zhuohan123 sorry it was a fat-finger, now fixed! (should have been 0.19.1)

@simon-mo simon-mo mentioned this pull request Apr 18, 2024
@njhill
Copy link
Member Author

njhill commented Apr 18, 2024

@simon-mo test failures look like flakes/network issues. Should we re-run or you think good to merge?

@simon-mo simon-mo disabled auto-merge April 18, 2024 21:36
@simon-mo simon-mo merged commit 87fa80c into vllm-project:main Apr 18, 2024
43 of 46 checks passed
@njhill njhill deleted the transformers-4.40 branch April 18, 2024 21:36
@simon-mo simon-mo mentioned this pull request Apr 18, 2024
9 tasks
xjpang pushed a commit to xjpang/vllm that referenced this pull request Apr 19, 2024
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 21, 2024
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Apr 26, 2024
alexeykondrat pushed a commit to alexeykondrat/ci-vllm that referenced this pull request May 1, 2024
z103cb pushed a commit to z103cb/opendatahub_vllm that referenced this pull request May 7, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants