-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Typing] Fix Sequence type GenericAlias only available after Python 3.9. #4092
Conversation
There's another one in utils.py of OrderedDict[...]. That the original author also found. Not sure what's the best way to catch this quickly. |
@simon-mo I guess the best way is to run CI against 3.8? should we have some sanity check tests there? (if you tell me how to do it, I can also include it in this PR) |
@simon-mo fixed the orderedDict as well. |
@rkooo567 can you create an github issue on this so I can leave some notes. |
Like Tuple or Deque type, Generic alias of some of built-in libraries are only available after Python 3.9. We are using collections.abc.Sequence's generic alias now, and this is not available in python 3.8 (it is available only from 3.9 similar to deque https://docs.python.org/3/library/typing.html#typing.Deque or tuple https://docs.python.org/3/library/typing.html#typing.Tuple)
While there are several approaches to fix, for examle
from __future__ import annotations
specified in this stackoverflow https://stackoverflow.com/questions/59955751/abcmeta-object-is-not-subscriptable-when-trying-to-annotate-a-hash-variable, I decided to just use typing.Sequence instead here because this is what we are doing with deque and tuple as well.I manually verified it doesn't raise object not subscriptable error in python 3.8. But lmk if you have any good idea to test this in CI.
Fixes #4081 (comment)
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!