-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test] Test multiple attn backend for chunked prefill. #4023
[Test] Test multiple attn backend for chunked prefill. #4023
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add other backends as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Does this change how we run the test locally? If so, can you change the comments on how to run the tests as well?
It doesn't change how it is tested locally because in that case, it just uses the default (same as master). But it'd be good to explain how to test different backends, so I will add comments to test files! |
@simon-mo I found there's torch sdpa and rocm. I assume rocm doesn't make much sense (can it run on cuda gpus?) and sdpa was for cpu? Do you suggest to add sdpa attn backend here? |
I believe the torch version can serve as a reference implementation. And the rocm is triton based? Please try it and if not working then feel free to remove them. |
SPDA -> it is not using GPU path anymore; 8afca50. So this PR won't cover it. ROCM -> there was a bug with naive attention, and I fixed it in this PR. None native attention + ROCM on GPU seems to fail with odd issue
So I didn't handle it |
I think the failures are unrelated, and it may be caused by #4012 |
I also notice this error, I will process it as soon as possible |
Add multi attn backend test for chunked prefill.
I also found the previous approach didin't work because of lru_cache usage
vllm/vllm/attention/selector.py
Line 24 in c2b4a1b
So I instead setting the env var from pipeline.yaml
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!