Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] LoRA gptbigcode implementation #3949

Merged
merged 6 commits into from
May 22, 2024

Conversation

raywanb
Copy link
Contributor

@raywanb raywanb commented Apr 9, 2024

Added lora adapters to gptbigcode

Resolves #3011

Copy link
Collaborator

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, please update the tests!

@raywanb
Copy link
Contributor Author

raywanb commented Apr 10, 2024

Thanks, please update the tests!

Done!

@Yard1
Copy link
Collaborator

Yard1 commented Apr 10, 2024

@raywanb great, all that's left is to run ./format.sh to make lint pass

@Yard1 Yard1 enabled auto-merge (squash) April 10, 2024 21:49
@Yard1 Yard1 changed the title Ray/lora gptbigcode implementation [Model] LoRA gptbigcode implementation Apr 10, 2024
auto-merge was automatically disabled April 10, 2024 23:17

Head branch was pushed to by a user without write access

@raywanb
Copy link
Contributor Author

raywanb commented Apr 11, 2024

@Yard1 it's ready to merge!

@njhill
Copy link
Member

njhill commented May 13, 2024

@raywanb could you resolve the conflicts one more time 🙏

@raywanb
Copy link
Contributor Author

raywanb commented May 20, 2024

@raywanb could you resolve the conflicts one more time 🙏

just did!

@njhill
Copy link
Member

njhill commented May 20, 2024

Thanks @raywanb! Could you please also run the linter on the final changes to fix those errors? (./format.sh)

@njhill
Copy link
Member

njhill commented May 20, 2024

@raywanb the lora CI test failures also look suspicious, these aren't currently failing on the main branch. cc @Yard1

@Yard1
Copy link
Collaborator

Yard1 commented May 20, 2024

Yeah those are real failures...

@raywanb raywanb force-pushed the ray/lora-gptbigcode-implementation branch from ecedab9 to ac60dba Compare May 21, 2024 05:36
@njhill
Copy link
Member

njhill commented May 21, 2024

@raywanb thanks for the updates! It looks like the lora tests are still failing though.

There was an issue in the main branch but I don't think that's the cause. Would be good if you could merge in main again once #4944 has been merged and then check the failures..

@raywanb
Copy link
Contributor Author

raywanb commented May 21, 2024

Yep will look into it later today

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raywanb! @Yard1 is this still good with you to merge?

@njhill njhill merged commit 97b0300 into vllm-project:main May 22, 2024
62 checks passed
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request May 31, 2024
njhill added a commit that referenced this pull request May 31, 2024
This was recently added in #3949 but we forgot to update the doc.
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 8, 2024
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
robertgshaw2-neuralmagic pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jul 14, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPTBigCodeForCausalLM LoRA support
3 participants