-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Fix beam search test #2930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix.
Please note that the proposed change currently only reads the first line (i.e., the first prompt) of the file and ignores the others. AFAIU, the beam search test fails on the second prompt. I believe the fix should be applied to the beam search test. A temporary solution would be to pass only the first prompt to the beam search test. This way, all other tests relying on |
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Thanks for pointing this out! Changed this PR accordingly. |
@zhuohan123 Let's merge it? |
Revert a change in #2869 that causes beam search test to fail.