-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
Remove Yi model definition, please use LlamaForCausalLM
instead
#2854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Roy <jasonailu87@gmail.com>
I tested the PR with
I don't even think the old codepath was used in most cases, because Yi on huggingface is now using Llama: https://huggingface.co/01-ai/Yi-6B/blob/main/config.json, https://huggingface.co/01-ai/Yi-34B/blob/main/config.json |
LlamaForCausalLM
insteadLlamaForCausalLM
instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a minor comment.
This should close #1899 |
…lm-project#2854) Co-authored-by: Roy <jasonailu87@gmail.com>
…lm-project#2854) Co-authored-by: Roy <jasonailu87@gmail.com>
…lm-project#2854) Co-authored-by: Roy <jasonailu87@gmail.com>
…lm-project#2854) Co-authored-by: Roy <jasonailu87@gmail.com>
This is ported over from #2637 and removes the Yi model definition. The Yi architecture is the same as Llama and using
LlamaForCausalLM
instead has the advantage that it prevents code duplication and makes sure the Yi models inherit all the fixes we make for llama, like LoRA support.This was the diff of the models: