migrate pydantic from v1 to v2 #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduced with vllm-project#2360 was not here before
simon-mo
approved these changes
Jan 21, 2024
This was referenced Jan 21, 2024
|
I was just fixing this also in parallel :-) |
|
Thank you for the contribution! |
This was referenced Jan 22, 2024
|
Why does it still show ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behavior is the source of the following dependency conflicts. |
|
This commit will be part of up coming vLLM 0.2.8, which will be releaesed in <1 week |
|
Seems pydantic v2 leads to a problem meet in #2619 |
3 tasks
hongxiayang
pushed a commit
to hongxiayang/vllm
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this guide here: https://docs.pydantic.dev/dev/migration/
Previous attempts: #2468 #2322
closes #1396
closes #2313
closes #2322
It also includes a fix to error code propagation for the OpenAI-compatible server.