-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
[Core] Support configuration parsing plugin #24277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
acb78b2
introduce config parser
charlotte12l 67f20b2
add tests
charlotte12l 6904978
clean comments
charlotte12l b4a6715
add docstring
charlotte12l 60d06d6
add __init__
charlotte12l 1f651de
change value error string
charlotte12l afee616
Update tests name
charlotte12l 75e613e
update string
charlotte12l 71cb21b
Merge branch 'main' into config_registry
charlotte12l ad3edfb
make ConfigFormat Literal
charlotte12l d4b2a1a
add metavar
charlotte12l 22fb0a6
update metavar
charlotte12l ab09ecb
Merge branch 'main' into config_registry
charlotte12l 6620df7
update arg_utils
charlotte12l 576a94c
Merge branch 'config_registry' of ssh://github.com/charlotte12l/vllm …
charlotte12l File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-FileCopyrightText: Copyright contributors to the vLLM project | ||
|
|
||
| from pathlib import Path | ||
| from typing import Optional, Union | ||
|
|
||
| import pytest | ||
| from transformers import PretrainedConfig | ||
|
|
||
| from vllm.transformers_utils.config import (get_config_parser, | ||
| register_config_parser) | ||
| from vllm.transformers_utils.config_parser_base import ConfigParserBase | ||
|
|
||
|
|
||
| @register_config_parser("custom_config_parser") | ||
| class CustomConfigParser(ConfigParserBase): | ||
|
|
||
| def parse(self, | ||
| model: Union[str, Path], | ||
| trust_remote_code: bool, | ||
| revision: Optional[str] = None, | ||
| code_revision: Optional[str] = None, | ||
| **kwargs) -> tuple[dict, PretrainedConfig]: | ||
| raise NotImplementedError | ||
|
|
||
|
|
||
| def test_register_config_parser(): | ||
| assert isinstance(get_config_parser("custom_config_parser"), | ||
| CustomConfigParser) | ||
|
|
||
|
|
||
| def test_invalid_config_parser(): | ||
| with pytest.raises(ValueError): | ||
|
|
||
| @register_config_parser("invalid_config_parser") | ||
| class InvalidConfigParser: | ||
| pass | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this directory to "Async Engine, Inputs, Utils, Worker Test" so it's actually being run in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Added in #24615