[ROCm] Upgrade xformers version dependency for ROCm; update documentations #2079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tjtanaa
commented
Dec 13, 2023
tjtanaa
commented
- Upgraded the xformers version for ROCm to match the one used in CUDA.
- Update documentations
WoosukKwon
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Hi @tjtanaa, thanks for submitting the PR! Left some minor comments. Please take a look at them.
WoosukKwon
reviewed
Dec 13, 2023
WoosukKwon
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.