Skip to content

[Misc] refactor example - openai_transcription_client #19851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

reidliu41
Copy link
Contributor

@reidliu41 reidliu41 commented Jun 19, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

  • move to main() and keep the style with the other examples
  • add the description and comments

Test Plan

Test Result

(Optional) Documentation Update

Signed-off-by: reidliu41 <reid201711@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @reidliu41, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the maintainability and readability of the openai_transcription_client.py example script. The primary changes involve restructuring the script's entry point to follow standard Python conventions and significantly enhancing its documentation through detailed docstrings, making it easier for users and future contributors to understand and utilize.

Highlights

  • Code Structure Refinement: The script's main execution logic has been encapsulated within a main() function, and the standard if __name__ == "__main__": block has been added. This improves the script's reusability and aligns its structure with common Python best practices and other examples in the repository.
  • Enhanced Documentation: A comprehensive module-level docstring has been added to examples/online_serving/openai_transcription_client.py, providing a clear overview of the script's purpose, prerequisites, and how to run the vLLM server. Additionally, docstrings have been added to the sync_openai() and stream_openai_response() functions to explain their specific functionalities.
  • Output Formatting Improvement: A minor adjustment was made to ensure a final newline character is printed after the streaming transcription output, improving readability in the console.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the documentation Improvements or additions to documentation label Jun 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the openai_transcription_client.py example script. The main changes include:

  • Comprehensive Documentation: Addition of a module-level docstring explaining the script's purpose, setup, requirements, and functionality. Docstrings were also added to the sync_openai and stream_openai_response functions, enhancing code readability and maintainability.
  • Structural Improvements: The script's execution logic has been encapsulated within a main() function, invoked via the standard if __name__ == "__main__": guard. This is a common Python best practice that improves script organization.
  • Usability Enhancement: A print() statement was added after the streaming transcription to ensure the command prompt appears on a new line, improving the CLI user experience.

Overall, these changes significantly improve the example script's clarity, maintainability, and adherence to common Python coding standards (like PEP 8 and PEP 257 for docstrings). The refactoring makes the example more robust and easier to understand for users.

No issues of medium, high, or critical severity were identified in the provided code changes.

One minor process note: the PR description checklist (Essential Elements of an Effective PR Description Checklist) is mostly unfilled. For future PRs, especially more complex ones, filling out sections like 'Test Plan' and 'Test Result' (even if briefly for examples, e.g., "Manually executed script, confirmed output matches expectations") would be beneficial for reviewers and project history.

@reidliu41
Copy link
Contributor Author

@DarkLight1337 could you please help to take a look if you have time? thanks

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 20, 2025 04:27
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 20, 2025
@DarkLight1337 DarkLight1337 merged commit e384f2f into vllm-project:main Jun 20, 2025
60 checks passed
yeqcharlotte pushed a commit to yeqcharlotte/vllm that referenced this pull request Jun 22, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
juncheoll pushed a commit to juncheoll/vllm that referenced this pull request Jun 23, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: juncheoll <th6re8e@naver.com>
fhl2000 pushed a commit to fhl2000/vllm that referenced this pull request Jun 25, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: fhl <2410591650@qq.com>
gmarinho2 pushed a commit to gmarinho2/vllm that referenced this pull request Jun 26, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 30, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Will Eaton <weaton@redhat.com>
wseaton pushed a commit to wseaton/vllm that referenced this pull request Jun 30, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
wwl2755-google pushed a commit to wwl2755-google/vllm that referenced this pull request Jul 1, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
avigny pushed a commit to avigny/vllm that referenced this pull request Jul 31, 2025
…9851)

Signed-off-by: reidliu41 <reid201711@gmail.com>
Co-authored-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants