-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[Misc] refactor example - openai_transcription_client #19851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] refactor example - openai_transcription_client #19851
Conversation
Signed-off-by: reidliu41 <reid201711@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @reidliu41, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the maintainability and readability of the openai_transcription_client.py
example script. The primary changes involve restructuring the script's entry point to follow standard Python conventions and significantly enhancing its documentation through detailed docstrings, making it easier for users and future contributors to understand and utilize.
Highlights
- Code Structure Refinement: The script's main execution logic has been encapsulated within a
main()
function, and the standardif __name__ == "__main__":
block has been added. This improves the script's reusability and aligns its structure with common Python best practices and other examples in the repository. - Enhanced Documentation: A comprehensive module-level docstring has been added to
examples/online_serving/openai_transcription_client.py
, providing a clear overview of the script's purpose, prerequisites, and how to run the vLLM server. Additionally, docstrings have been added to thesync_openai()
andstream_openai_response()
functions to explain their specific functionalities. - Output Formatting Improvement: A minor adjustment was made to ensure a final newline character is printed after the streaming transcription output, improving readability in the console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the openai_transcription_client.py
example script. The main changes include:
- Comprehensive Documentation: Addition of a module-level docstring explaining the script's purpose, setup, requirements, and functionality. Docstrings were also added to the
sync_openai
andstream_openai_response
functions, enhancing code readability and maintainability. - Structural Improvements: The script's execution logic has been encapsulated within a
main()
function, invoked via the standardif __name__ == "__main__":
guard. This is a common Python best practice that improves script organization. - Usability Enhancement: A
print()
statement was added after the streaming transcription to ensure the command prompt appears on a new line, improving the CLI user experience.
Overall, these changes significantly improve the example script's clarity, maintainability, and adherence to common Python coding standards (like PEP 8 and PEP 257 for docstrings). The refactoring makes the example more robust and easier to understand for users.
No issues of medium
, high
, or critical
severity were identified in the provided code changes.
One minor process note: the PR description checklist (Essential Elements of an Effective PR Description Checklist) is mostly unfilled. For future PRs, especially more complex ones, filling out sections like 'Test Plan' and 'Test Result' (even if briefly for examples, e.g., "Manually executed script, confirmed output matches expectations") would be beneficial for reviewers and project history.
@DarkLight1337 could you please help to take a look if you have time? thanks |
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: juncheoll <th6re8e@naver.com>
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: fhl <2410591650@qq.com>
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: Will Eaton <weaton@redhat.com>
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com>
…9851) Signed-off-by: reidliu41 <reid201711@gmail.com> Co-authored-by: reidliu41 <reid201711@gmail.com> Signed-off-by: avigny <47987522+avigny@users.noreply.github.com>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update