Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix quickstart.rst example #1964

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Fix quickstart.rst example #1964

merged 1 commit into from
Dec 7, 2023

Conversation

gottlike
Copy link
Contributor

@gottlike gottlike commented Dec 7, 2023

This confused me a bit, but I figured it's just a typo (was .json instead of .jinja)

simon-mo
simon-mo approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@simon-mo simon-mo merged commit 42c02f5 into vllm-project:main Dec 7, 2023
2 checks passed
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@gottlike
Fix quickstart.rst typo jinja (vllm-project#1964)
61b5431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gottlike @simon-mo