[CI][Neuron] Fail and exit on first error #19622
Conversation
Signed-off-by: Elaine Zhao <elaineyz@amazon.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @elaineyz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the robustness of the Neuron CI test script by implementing immediate failure upon encountering the first error. This change is intended to prevent silent failures where later tests might pass despite an earlier test failing, providing clearer and faster feedback on test results.
Highlights
- Error Handling: Added
set -eto the bash script executed within the docker container. This ensures that the script will exit immediately upon the first command failure, preventing subsequent tests from running and potentially masking earlier errors. - Script Syntax: Updated the
echocommand used within the loop to print the current test file name. Changed from single quotes (') to double quotes (") around the variable$fto ensure correct variable expansion within the string.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request enhances the CI script by adding set -e to ensure immediate failure on errors, which is a good improvement for script robustness. The modification to the echo command, however, could introduce issues if filenames contain double quotes. I've suggested using printf for that line to handle such cases more safely.
Signed-off-by: aws-elaineyz <elaineyz@amazon.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
elaineyz
force-pushed
the
buildkite_script_update
branch
from
d29cc8e to
2c0b7aa
Compare
This reverts commit 2c0b7aa. Signed-off-by: Elaine Zhao <elaineyz@amazon.com>
elaineyz
force-pushed
the
buildkite_script_update
branch
from
88b5de2 to
7853451
Compare
elaineyz
added
aws-neuron
|
@DarkLight1337 / @simon-mo / @WoosukKwon can you help approve and merge this minor change? thanks! |
Signed-off-by: Elaine Zhao <elaineyz@amazon.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Elaine Zhao <elaineyz@amazon.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: juncheoll <th6re8e@naver.com>
Signed-off-by: Elaine Zhao <elaineyz@amazon.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: minpeter <kali2005611@gmail.com>
Signed-off-by: Elaine Zhao <elaineyz@amazon.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: fhl <2410591650@qq.com>
Signed-off-by: Elaine Zhao <elaineyz@amazon.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Purpose
Update the neuron buildkite script to fail on first errored file. This will prevent errors getting ignored silently.
Test Plan
I first ran the updated bash command locally to make sure all tests are still passing; next I temporarily modified one of the neuron test scripts to raise an arbitrary exception and verified that the command terminates immediately.
Test Result
See above
(Optional) Documentation Update