-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
[ROCm][Build] Clean up the ROCm build #19040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ROCm fork. Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
@@ -12,5 +12,7 @@ ray>=2.10.0,<2.45.0 | |||
peft | |||
pytest-asyncio | |||
tensorizer>=2.9.0 | |||
setuptools-scm>=8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
btw, what's the difference between rocm.txt and rocm-build.txt? One for runtime, one for build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rocm-build.txt is used to build standalone bare metal, introduced by @SageMoore
rocm.txt is used for build and run in the official AMD docker, one important difference is that in this release we can not use pytorch from whl, so can't include it in the requirements.
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Cleanup the ROCm build related files and build related files and sync up with ROCm fork.
Cleaning up the dockerfile from obsolete tools
Adding missing build requirements since rocm doesn't include requirements/build.txt