Skip to content

[ROCm][Build] Clean up the ROCm build #19040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented Jun 2, 2025

Cleanup the ROCm build related files and build related files and sync up with ROCm fork.

Cleaning up the dockerfile from obsolete tools
Adding missing build requirements since rocm doesn't include requirements/build.txt

…ROCm fork.

Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Copy link

github-actions bot commented Jun 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@gshtras gshtras added the rocm Related to AMD ROCm label Jun 2, 2025
@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Jun 2, 2025
@@ -12,5 +12,7 @@ ray>=2.10.0,<2.45.0
peft
pytest-asyncio
tensorizer>=2.9.0
setuptools-scm>=8
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, what's the difference between rocm.txt and rocm-build.txt? One for runtime, one for build?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should be reverted

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rocm-build.txt is used to build standalone bare metal, introduced by @SageMoore
rocm.txt is used for build and run in the official AMD docker, one important difference is that in this release we can not use pytorch from whl, so can't include it in the requirements.

@vllm-bot vllm-bot merged commit 9e6f61e into vllm-project:main Jun 3, 2025
15 checks passed
@pramenku
Copy link

pramenku commented Jun 3, 2025

@gshtras can we also remove this from Dockerfile.rocm because rocm.txt/rocm-build.txt has already so redundant can be removed.

RUN python3 -m pip install --upgrade pip && pip install setuptools_scm

&& pip install setuptools_scm

@gshtras gshtras deleted the rocm_build_tweaks branch June 3, 2025 14:53
gshtras added a commit to ROCm/vllm that referenced this pull request Jun 3, 2025
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
gshtras added a commit to ROCm/vllm that referenced this pull request Jun 3, 2025
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation rocm Related to AMD ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants