Skip to content

[Bugfix] Use cmake 3.26.1 instead of 3.26 to avoid build failure #19019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

houseroad
Copy link
Collaborator

@houseroad houseroad commented Jun 2, 2025

To address #18748

Test plan:

Verified with cmake 3.26.0 (problematic), 3.26.1, 3.27.9, 3.30.5, 4.0.2. All others are good, only 3.26.0 only generate _C.so, not _C.abi3.so.

python setup.py develop with cmake==3.26.0

-- Install configuration: "RelWithDebInfo"
-- Installing: /home/lufang/gitrepos/vllm/build/lib.linux-x86_64-cpython-310/vllm/_moe_C.so
-- Set runtime path of "/home/lufang/gitrepos/vllm/build/lib.linux-x86_64-cpython-310/vllm/_moe_C.so" to ""
-- Install configuration: "RelWithDebInfo"
-- Installing: /home/lufang/gitrepos/vllm/build/lib.linux-x86_64-cpython-310/vllm/_rocm_C.so
-- Set runtime path of "/home/lufang/gitrepos/vllm/build/lib.linux-x86_64-cpython-310/vllm/_rocm_C.so" to ""
-- Install configuration: "RelWithDebInfo"
-- Installing: /home/lufang/gitrepos/vllm/build/lib.linux-x86_64-cpython-310/vllm/_C.so
-- Set runtime path of "/home/lufang/gitrepos/vllm/build/lib.linux-x86_64-cpython-310/vllm/_C.so" to ""
error: can't copy 'build/lib.linux-x86_64-cpython-310/vllm/_moe_C.abi3.so': doesn't exist or not a regular file

python setup.py develop with cmake>=3.26.1

Using /home/lufang/gitrepos/vllm/.venv/lib/python3.10/site-packages
Finished processing dependencies for vllm==0.9.1.dev108+g432ec9926.d20250602.rocm631

Signed-off-by: Lu Fang <lufang@fb.com>
@houseroad houseroad requested a review from hmellor as a code owner June 2, 2025 11:27
Copy link

github-actions bot commented Jun 2, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@houseroad houseroad requested a review from youkaichao June 2, 2025 11:27
@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Jun 2, 2025
@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 2, 2025
@houseroad houseroad requested review from khluu and DarkLight1337 June 2, 2025 11:29
@DarkLight1337 DarkLight1337 requested a review from mgoin June 2, 2025 11:34
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down, LGTM. FYI @bnellnm

@houseroad houseroad enabled auto-merge (squash) June 2, 2025 15:13
@simon-mo simon-mo disabled auto-merge June 3, 2025 07:16
@simon-mo simon-mo merged commit d32aa2e into vllm-project:main Jun 3, 2025
101 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants