[CI] change spell checker from codespell to typos #18711

andyxning · 2025-05-26T12:12:57Z

Currently, codespell can not help in finding all possible typos. According to this comparison, it seems typos has more good performance and correctness. typos also supports both pre-commit and Github actions.

github-actions · 2025-05-26T12:13:06Z

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

DarkLight1337

Overall this looks reasonable to me. Can you remove the codespell config from pyproject.toml?

DarkLight1337 · 2025-05-26T14:18:24Z

@mgoin can you verify that the changes to the kernels are OK?

mgoin

Please revert the changes to cudaDevAttrMaxSharedMemoryPerBlockOptin and the transformers test

I don't know if I like this. I think it will be annoying and error-prone if developers need to define functional exceptions like this during their work

mgoin · 2025-05-26T15:11:25Z

csrc/cuda_utils_kernels.cu

-  attribute = cudaDevAttrMaxSharedMemoryPerBlockOptin;
+  attribute = cudaDevAttrMaxSharedMemoryPerBlockOption;


I don't think this is valid. I think Optin is right here

Seems cudaDevAttrMaxSharedMemoryPerBlockOptin is predefined in cuda sdk. Will do.

mgoin · 2025-05-26T15:13:47Z

csrc/cutlass_extensions/common.hpp

@@ -18,7 +18,7 @@
 inline int get_cuda_max_shared_memory_per_block_opt_in(int const device) {
  int max_shared_mem_per_block_opt_in = 0;
  cudaDeviceGetAttribute(&max_shared_mem_per_block_opt_in,
-                         cudaDevAttrMaxSharedMemoryPerBlockOptin, device);


mgoin · 2025-05-26T15:13:59Z

csrc/moe/marlin_moe_wna16/ops.cu

@@ -584,7 +584,7 @@ void marlin_mm(const void* A, const void* B, void* C, void* C_tmp, void* s,

  int max_shared_mem = 0;
  cudaDeviceGetAttribute(&max_shared_mem,
-                         cudaDevAttrMaxSharedMemoryPerBlockOptin, dev);


mgoin · 2025-05-26T15:14:11Z

csrc/moe/moe_align_sum_kernels.cu

@@ -302,7 +302,7 @@ void moe_align_block_size(torch::Tensor topk_ids, int64_t num_experts,
  int device_max_shared_mem;
  auto dev = topk_ids.get_device();
  cudaDeviceGetAttribute(&device_max_shared_mem,
-                         cudaDevAttrMaxSharedMemoryPerBlockOptin, dev);


andyxning · 2025-05-26T15:53:42Z

Overall this looks reasonable to me. Can you remove the codespell config from pyproject.toml?

@DarkLight1337 Done.

andyxning · 2025-05-26T15:58:36Z

I think it will be annoying and error-prone if developers need to define functional exceptions like this during their work

Yes. this is true. Some trade-off needs to be done if we decide to apply this PR.

mergify · 2025-05-26T16:59:04Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @andyxning.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mgoin · 2025-05-26T17:14:00Z

tests/lora/test_transforms_model.py

Can you fix this? Maybe we can disable renaming files entirely

Yes. Will do.

@mgoin file name spelling check has been disabled by setting check-filename to false in typos.yaml file.

Signed-off-by: Andy Xie <andy.xning@gmail.com>

andyxning · 2025-05-27T02:59:43Z

It seems that most special escapes in spell checking are about cuda and nvml.

https://github.com/vllm-project/vllm/pull/18711/files#diff-51afc5d77bc899fd07f13239bccc4c8042af7062b994c4ce493d8123f905f5a4R21-R48

Other changes in this PR are clean and clear enough. There are two options about this spell check change to the later developing overhead:

ignore checking all the c++ and nvml related files. This should make most special escapes deleted and has the lowest overhead for developing the project laterly.
keep current special escapes and make them maintained as needed in the later developing phase. This will involve some manual operations, but since the codebase has been analysed and most special escapes has been discovered, the manual operations overhead depends on the develop frequencies in cuda and nvml related code. This should be not so much, imho. Correct me if i am wrong.

So, i prefer option 2.

/cc @mgoin

mergify · 2025-05-31T15:36:39Z

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @andyxning.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

andyxning requested review from jeejeelee, njhill, LiuXiaoxuanPKU, tlrmchlsmth, WoosukKwon, robertgshaw2-redhat, ywang96, comaniac, alexm-redhat, DarkLight1337 and mgoin as code owners May 26, 2025 12:12

mergify bot added documentation Improvements or additions to documentation frontend multi-modality Related to multi-modality (#4194) speculative-decoding v1 tpu Related to Google TPUs tool-calling labels May 26, 2025

github-project-automation bot added this to Tool Calling May 26, 2025

andyxning force-pushed the change_spell_checker_from_codespell_to_typos branch from 9e8461d to 2fb888e Compare May 26, 2025 12:55

DarkLight1337 reviewed May 26, 2025

View reviewed changes

mgoin reviewed May 26, 2025

View reviewed changes

andyxning force-pushed the change_spell_checker_from_codespell_to_typos branch from 2fb888e to 9e2ee0b Compare May 26, 2025 15:47

andyxning requested a review from simon-mo as a code owner May 26, 2025 15:47

andyxning force-pushed the change_spell_checker_from_codespell_to_typos branch from 9e2ee0b to d592a3e Compare May 26, 2025 15:53

andyxning force-pushed the change_spell_checker_from_codespell_to_typos branch from d592a3e to ccd6843 Compare May 26, 2025 16:10

mergify bot added the needs-rebase label May 26, 2025

mgoin reviewed May 26, 2025

View reviewed changes

andyxning force-pushed the change_spell_checker_from_codespell_to_typos branch from ccd6843 to e87514b Compare May 27, 2025 02:37

mergify bot removed the needs-rebase label May 27, 2025

andyxning force-pushed the change_spell_checker_from_codespell_to_typos branch from e87514b to 5ef5dab Compare May 27, 2025 02:40

[CI] change spell checker from codespell to typos

0b52b3e

Signed-off-by: Andy Xie <andy.xning@gmail.com>

andyxning force-pushed the change_spell_checker_from_codespell_to_typos branch from 5ef5dab to 0b52b3e Compare May 27, 2025 02:47

andyxning requested review from DarkLight1337 and mgoin May 27, 2025 04:06

mergify bot added the needs-rebase label May 31, 2025

		attribute = cudaDevAttrMaxSharedMemoryPerBlockOptin;
		attribute = cudaDevAttrMaxSharedMemoryPerBlockOption;

Uh oh!

[CI] change spell checker from codespell to typos #18711

Are you sure you want to change the base?

[CI] change spell checker from codespell to typos #18711

Conversation

andyxning commented May 26, 2025

Uh oh!

github-actions bot commented May 26, 2025

Uh oh!

DarkLight1337 left a comment

Choose a reason for hiding this comment

Uh oh!

DarkLight1337 commented May 26, 2025

Uh oh!

mgoin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andyxning commented May 26, 2025

Uh oh!

andyxning commented May 26, 2025

Uh oh!

mergify bot commented May 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andyxning commented May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented May 31, 2025

Uh oh!

Uh oh!

andyxning commented May 27, 2025 •

edited

Loading