Skip to content

[V1] [Spec decode] Llama4 type eagle support in v1 #18369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RonaldBXu
Copy link
Contributor

@RonaldBXu RonaldBXu commented May 19, 2025

This PR adds the capability for llama4-type eagle heads to be used for speculative decoding in vLLM v1. This is my first major PR in vLLM, so feedback is appreciated : )

Signed-off-by: Ronald Xu <ronaldxu@amazon.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@sarckk
Copy link
Collaborator

sarckk commented May 19, 2025

cc @zixi-qi @morgendave

@RonaldBXu RonaldBXu closed this May 19, 2025
@RonaldBXu RonaldBXu reopened this May 19, 2025
@RonaldBXu RonaldBXu closed this May 19, 2025
@RonaldBXu RonaldBXu reopened this May 21, 2025
@RonaldBXu
Copy link
Contributor Author

Ready for review now

@WoosukKwon
Copy link
Collaborator

@RonaldBXu Looks good to me overall. Could you please add a test? Also, is there any available EAGLE head we can test this on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants