-
-
Notifications
You must be signed in to change notification settings - Fork 9k
[BugFix] [Vul] Add missing usedforsecurity=False
in MD5 hashing to enable FIPS
#18319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…-project#18243) Signed-off-by: cascade812 <cascade812@outlook.com> Signed-off-by: shaoyuyoung <shaoyuyoung@gmail.com>
Signed-off-by: shaoyuyoung <shaoyuyoung@gmail.com>
0f197b4
to
cf48263
Compare
I'm very sorry that some checking mechanisms were triggered when I updated the branch |
Signed-off-by: shaoyuyoung <shaoyuyoung@gmail.com>
…into fix_md5_hashing
|
cc @russellb, mind taking a look at this? thanks! :) |
Thanks @shaoyuyoung |
Would you be make the CI check to avoid future actions that break FIPS compliance? |
Sure thing! :) |
The previous CI seemed to trigger a Docker error. I'm not sure whether it is my issue. Can we rerun the CI? |
Warning |
…enable FIPS (vllm-project#18319) Signed-off-by: cascade812 <cascade812@outlook.com> Signed-off-by: shaoyuyoung <shaoyuyoung@gmail.com> Co-authored-by: cascade <cascade812@outlook.com> Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
…enable FIPS (vllm-project#18319) Signed-off-by: cascade812 <cascade812@outlook.com> Signed-off-by: shaoyuyoung <shaoyuyoung@gmail.com> Co-authored-by: cascade <cascade812@outlook.com> Signed-off-by: minpeter <kali2005611@gmail.com>
A supplement to the previous PR (#17043).
When it comes to
MD5 hashing
, we might meet the two problems below:usedforsecurity=False
) on FIPS, the program throwsValueError
.Solution: add the param
usedforsecurity=False
forhashlib.md5
BTW, I think we should add this vul pattern into vLLM CI check, avoiding the new unsafe use of md5 hashing to be introduced to the codebase.
FIX #18318
Warning
usedforsecurity=False
is a "do not explode in FIPS mode" flag to make software FIPS tolerant, not making the code comply with FIPS.