Skip to content

[Don't merge] Debug failing quantization test with input batch move #18298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

heheda12345
Copy link
Collaborator

@heheda12345 heheda12345 commented May 17, 2025

Similar to #18147, the input batch move in #17945 also causes quantization/test_cpu_offload.py::test_cpu_offload_gptq fail on main.

pytest -vs quantization/test_cpu_offload.py::test_cpu_offload_gptq
E                       AssertionError: Results for model='Qwen/Qwen2-1.5B-Instruct-GPTQ-Int4' are not the same.
E                       ref_args=['--quantization', 'gptq', '--enforce-eager'] ref_envs=None
E                       compare_args=['--quantization', 'gptq', '--cpu-offload-gb', '1', '--enforce-eager'] compare_envs=None
E                       ref_result={'test': 'seeded_sampling', 'text': ' Mike', 'finish_reason': 'length', 'usage': CompletionUsage(completion_tokens=1, prompt_tokens=5, total_tokens=6, completion_tokens_details=None, prompt_tokens_details=None)}
E                       compare_result={'test': 'seeded_sampling', 'text': '', 'finish_reason': 'length', 'usage': CompletionUsage(completion_tokens=1, prompt_tokens=5, total_tokens=6, completion_tokens_details=None, prompt_tokens_details=None)}

Signed-off-by: Chen Zhang <zhangch99@outlook.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link

mergify bot commented May 17, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @heheda12345.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

Copy link

mergify bot commented May 23, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @heheda12345.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label May 23, 2025
@mergify mergify bot added the qwen Related to Qwen models label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase qwen Related to Qwen models v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant