Skip to content

[Bugfix] fix rotary embedding test for _get_padded_tensor_shape #18229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

[Bugfix] fix rotary embedding test for _get_padded_tensor_shape #18229

merged 1 commit into from
May 16, 2025

Conversation

LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented May 15, 2025 •
edited by github-actions bot
Loading

Alternative fix for #18227

Makes sure we tests with padding and that the shapes match

@LucasWilkinson
fix batch rotary embedding test
b08b588 
Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@LucasWilkinson LucasWilkinson mentioned this pull request May 15, 2025
Closed
@LucasWilkinson LucasWilkinson requested a review from luccafong May 15, 2025 23:10
luccafong
luccafong reviewed May 15, 2025
View reviewed changes
Copy link
Collaborator

@luccafong luccafong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@simon-mo simon-mo enabled auto-merge (squash) May 15, 2025 23:59
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 15, 2025
@simon-mo simon-mo merged commit 4e1c6a0 into vllm-project:main May 16, 2025
55 of 57 checks passed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@LucasWilkinson
[Bugfix] fix rotary embedding test for _get_padded_tensor_shape (vllm…
27ff2a4 
…-project#18229)

Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@LucasWilkinson @minpeter
[Bugfix] fix rotary embedding test for _get_padded_tensor_shape (vllm…
0b1957d 
…-project#18229)

Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
@tanujtiwari1998 tanujtiwari1998 mentioned this pull request Jul 8, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

@luccafong luccafong luccafong approved these changes

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasWilkinson @simon-mo @luccafong