Skip to content

Update deprecated type hinting in platform, plugins, triton_utils, vllm_flash_attn #18129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Update deprecated type hinting in platform, plugins, triton_utils, vllm_flash_attn #18129

merged 2 commits into from
May 14, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 14, 2025

Removes deprecated Python 3.8 syntax.

N.B. also removes transformers_utils from the skip list in pyproject.toml, it must have been missed in the PR which updated the typing in that directory.

@hmellor
Update deprecated type hinting in platform, plugins, `triton_util…
df16bbc 
…s`, `vllm_flash_attn`

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the tpu Related to Google TPUs label May 14, 2025
@hmellor
pre-commit
8b71845 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 14, 2025 09:19
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 14, 2025
@vllm-bot vllm-bot merged commit c8ea982 into vllm-project:main May 14, 2025
58 of 64 checks passed
@hmellor hmellor deleted the deprecated-typing-several branch May 14, 2025 13:01
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@hmellor
Update deprecated type hinting in platform, plugins, `triton_util…
f284c76 
…s`, `vllm_flash_attn` (vllm-project#18129)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@hmellor @minpeter
Update deprecated type hinting in platform, plugins, `triton_util…
8782e75 
…s`, `vllm_flash_attn` (vllm-project#18129)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
@tanujtiwari1998 tanujtiwari1998 mentioned this pull request Jul 8, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmellor @DarkLight1337 @vllm-bot