Skip to content

[BUG] [ROCm] [MLA] Fix variable name bug due to change in variable name in PR #17483 #17961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2025
Merged

[BUG] [ROCm] [MLA] Fix variable name bug due to change in variable name in PR #17483 #17961

merged 1 commit into from
May 11, 2025

Conversation

tjtanaa
Copy link
Contributor

@tjtanaa tjtanaa commented May 11, 2025 •
edited by github-actions bot
Loading

This is to fix the error due to change of name introduced by PR #17483

the rename of the block_table to block_table_tensor in _build_decode function had broken AiterMLAMetadataBuilder._build_decode

@tjtanaa
fix variable name bug
48da914 
Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 11, 2025
@tjtanaa tjtanaa changed the title [BUG] [ROCm] [MLA] Fix variable name bug due to change in variable name in PR https://github.com/vllm-project/vllm/pull/17483 [BUG] [ROCm] [MLA] Fix variable name bug due to change in variable name in PR #17483 May 11, 2025
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 11, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 11, 2025 13:14
@tjtanaa tjtanaa mentioned this pull request May 11, 2025
Open
53 tasks
@vllm-bot vllm-bot merged commit 7de18d5 into vllm-project:main May 11, 2025
65 of 70 checks passed
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@tjtanaa
[BUG] [ROCm] [MLA] Fix variable name bug due to change in variable na…
2c7bfbf 
…me in PR vllm-project#17483 (vllm-project#17961)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@tjtanaa @mawong-amd
[BUG] [ROCm] [MLA] Fix variable name bug due to change in variable na…
cf52511 
…me in PR vllm-project#17483 (vllm-project#17961)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
@NickLucche NickLucche mentioned this pull request May 15, 2025
Closed
@tjtanaa tjtanaa deleted the aiter-mla-v1-bugfix branch May 16, 2025 16:28
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@tjtanaa
[BUG] [ROCm] [MLA] Fix variable name bug due to change in variable na…
0f3662f 
…me in PR vllm-project#17483 (vllm-project#17961)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@tjtanaa @minpeter
[BUG] [ROCm] [MLA] Fix variable name bug due to change in variable na…
52624f5 
…me in PR vllm-project#17483 (vllm-project#17961)

Signed-off-by: tjtanaa <tunjian.tan@embeddedllm.com>
Signed-off-by: minpeter <kali2005611@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjtanaa @DarkLight1337 @vllm-bot