Skip to content

[Model] Qwen3 Dense FP8 Compat Fixes #17318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

[Model] Qwen3 Dense FP8 Compat Fixes #17318

merged 2 commits into from
Apr 28, 2025

Conversation

simon-mo
Copy link
Collaborator

This is required to serve fp8 quantized models for upcoming release.

@simon-mo
[Model] Qwen3 Dense FP8 Compat Fixes
a647d99 
Signed-off-by: simon-mo <xmo@berkeley.edu>
@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 28, 2025
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@simon-mo simon-mo added this to the v0.8.5 milestone Apr 28, 2025
@simon-mo
lint
562f460 
Signed-off-by: simon-mo <xmo@berkeley.edu>
@simon-mo
Copy link
Collaborator Author

CI looks good. will merge once lint passed https://buildkite.com/vllm/ci/builds/18809/steps?sid=01967dd1-1e22-4bb4-adbb-0b7e6154168f

@simon-mo simon-mo merged commit dcbac4c into vllm-project:main Apr 28, 2025
10 of 14 checks passed
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@simon-mo @dbyoung18
[Model] Qwen3 Dense FP8 Compat Fixes (vllm-project#17318)
6bfc531 
Signed-off-by: simon-mo <xmo@berkeley.edu>
@255doesnotexist 255doesnotexist mentioned this pull request Apr 29, 2025
Open
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@simon-mo @lk-chen
[Model] Qwen3 Dense FP8 Compat Fixes (vllm-project#17318)
3c47b84 
Signed-off-by: simon-mo <xmo@berkeley.edu>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@simon-mo
[Model] Qwen3 Dense FP8 Compat Fixes (vllm-project#17318)
c5d3367 
Signed-off-by: simon-mo <xmo@berkeley.edu>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
yangulei pushed a commit to yangulei/vllm-fork that referenced this pull request May 13, 2025
@simon-mo @yangulei
[Model] Qwen3 Dense FP8 Compat Fixes (vllm-project#17318)
7d93dc4 
Signed-off-by: simon-mo <xmo@berkeley.edu>
@minedec minedec mentioned this pull request May 13, 2025
Closed
dtrifiro pushed a commit to red-hat-data-services/vllm that referenced this pull request May 13, 2025
@andy-neuma
Sync midstream to upstream v0.8.5.post1 (opendatahub-io#218)
7db80a0 
Syncing midstream NM fork to Upstream tag of
[v0.8.5.post1](https://github.com/vllm-project/vllm/tree/v0.8.5.post1) +
cherry pick of
vllm-project@be633fb
needed for benchmarks +
[CP](neuralmagic/nm-vllm-ent@1fe447d)
for compressed tensor bump +
[CP](vllm-project#17677) for lora on AMD +
[CP](vllm-project#17315) for llama4 w/ pure
dense layers

```
commit 31c73ba (HEAD -> upstream-v0.8.5, nm-fork/upstream-v0.8.5)
Author: Chauncey <chaunceyjiang@gmail.com>
Date:   Wed Apr 30 15:11:04 2025 +0800

    [Bugfix] Fix AttributeError: 'State' object has no attribute 'engine_client' (vllm-project#17434)
    
    Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>

commit f8db0bd
Author: Lucas Wilkinson <LucasWilkinson@users.noreply.github.com>
Date:   Fri May 2 14:01:38 2025 -0400

    [BugFix][Attention] Fix sliding window attention in V1 giving incorrect results (vllm-project#17574)
    
    Signed-off-by: Lucas Wilkinson <lwilkinson@neuralmagic.com>

commit e335c34
Author: Robert Shaw <114415538+robertgshaw2-redhat@users.noreply.github.com>
Date:   Fri May 2 04:07:03 2025 -0400

    [BugFix] Fix Memory Leak (vllm-project#17567)
    
    Signed-off-by: rshaw@neuralmagic.com <robertgshaw2@gmail.com>

commit cc463fe
Merge: 1e358ff ba41cc9
Author: Selbi Nuryyeva <selbi@redhat.com>
Date:   Tue Apr 29 12:34:57 2025 -0400

    Merge branch 'tag-upstream-v0.8.5' into upstream-v0.8.5

commit ba41cc9 (tag: v0.8.5, tag-upstream-v0.8.5)
Author: Michael Goin <mgoin64@gmail.com>
Date:   Mon Apr 28 16:20:24 2025 -0600

    [Model] Add tuned triton fused_moe configs for Qwen3Moe (vllm-project#17328)
    
    Signed-off-by: mgoin <mgoin64@gmail.com>

commit dcbac4c
Author: Simon Mo <simon.mo@hey.com>
Date:   Mon Apr 28 14:12:01 2025 -0700

    [Model] Qwen3 Dense FP8 Compat Fixes (vllm-project#17318)
    
    Signed-off-by: simon-mo <xmo@berkeley.edu>
[...]
```

Commands
```
git fetch upstream
git checkout -b upstream-v0.8.5
git merge upstream/v0.8.5
git cherry-pick be633fb
```

TEST PLAN
accept sync:
https://github.com/neuralmagic/nm-cicd/actions/runs/14841223552
related PR in cicd: neuralmagic/nm-cicd#99
release workflow:
https://github.com/neuralmagic/nm-cicd/actions/runs/14845693864
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@simon-mo
[Model] Qwen3 Dense FP8 Compat Fixes (vllm-project#17318)
eb0f761 
Signed-off-by: simon-mo <xmo@berkeley.edu>
Signed-off-by: Yuqi Zhang <yuqizhang@google.com>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@simon-mo @minpeter
[Model] Qwen3 Dense FP8 Compat Fixes (vllm-project#17318)
7c08b94 
Signed-off-by: simon-mo <xmo@berkeley.edu>
Signed-off-by: minpeter <kali2005611@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
v0.8.5
Development

Successfully merging this pull request may close these issues.
1 participant
@simon-mo