Skip to content

Improve configs - CacheConfig #16835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 20, 2025
Merged

Improve configs - CacheConfig #16835

merged 8 commits into from
Apr 20, 2025

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented Apr 18, 2025 •
edited
Loading

Follows #16332, #16422, #16533, #16603, #16789

Notable change:

  • The conversion of docstring to argparse help string now escapes the % symbol

hmellor added 3 commits April 18, 2025 11:40
@hmellor
Escape % for argparse when converting docstrings to help text
6ebf0a4 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Improve CacheConfig
12d57f8 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Make mypy happy for Neuron
dee4592 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@hmellor hmellor changed the title Improve-cache-config Improve configs - CacheConfig Apr 18, 2025
DarkLight1337
DarkLight1337 reviewed Apr 18, 2025
View reviewed changes
@hmellor
Review comment
6187f23 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
DarkLight1337
DarkLight1337 approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the test failure caused by #16835 in this PR? Otherwise LGTM

@hmellor
Copy link
Member Author

hmellor commented Apr 18, 2025 •
edited
Loading

The error discussed on Slack came from #16789, and I've already made a separate PR for it in #16837

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 18, 2025
@hmellor
Copy link
Member Author

hmellor commented Apr 18, 2025

The failure in lint-and-deploy looks relevant, I'll look into it

hmellor added 2 commits April 18, 2025 12:43
@hmellor
Fix missing arg
fb7c0fb 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Merge branch 'main' into improve-cache-config
ca07a4e
@DarkLight1337
Copy link
Member

Tests are failing

hmellor added 2 commits April 18, 2025 16:00
@hmellor
Cannot default enable_prefix_caching because it needs oracle
ead8ed6 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor
Metrics tests failed when swap_space_bytes was a property instead…
1dabfea 
… of an `attr`

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@DarkLight1337 DarkLight1337 merged commit 4b07d36 into vllm-project:main Apr 20, 2025
47 checks passed
@hmellor hmellor deleted the improve-cache-config branch April 20, 2025 07:30
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@hmellor @yangw-dev
Improve configs - CacheConfig (vllm-project#16835)
4d93211 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
@hmellor hmellor mentioned this pull request Apr 22, 2025
Merged
This was referenced Apr 22, 2025
Merged
Merged
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@hmellor @dbyoung18
Improve configs - CacheConfig (vllm-project#16835)
7295cf5 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@hmellor @lk-chen
Improve configs - CacheConfig (vllm-project#16835)
bb382a4 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@hmellor @adobrzyn
Improve configs - CacheConfig (vllm-project#16835)
9c4d68d 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@hmellor hmellor mentioned this pull request Apr 30, 2025
Merged
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@hmellor
Improve configs - CacheConfig (vllm-project#16835)
e91f343 
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Mu Huai <tianbowen.tbw@antgroup.com>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
@DarkLight1337 DarkLight1337 mentioned this pull request Jun 21, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmellor @DarkLight1337