-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Misc] Disable pin_memory in AsyncMetricsCollector for spec decode tensor allocation #15886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: roy <jasonailu87@gmail.com>
…s.py Signed-off-by: roy <jasonailu87@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @esmeetu, good to see you again!
I don't quite understand your problem here. IIUC, these tensors are CPU tensors, so shouldn't take any GPU memory?
For what it's worth, I was actually also seeing this issue - when setting a speculative decoding config, no matter what I would also see the same behaviour that 1.4GB per TP would be allocated to CUDA0. This PR fixes that. Thank you! |
@WoosukKwon Yeah, busy year. Glad to get your review again.: ) I have same confusion with you, but i think it might like that pytorch precache a buffer in gpu space for the coming data transfer. |
This pull request has merge conflicts that must be resolved before it can be |
I encountered a memory issue when using tensor parallelism with speculative decoding. On rank 0, it consumes approximately 1.4GB multiplied by the TP count, which is quite large for a single GPU with limited memory.
Since the
_aggregate_num_accepted_tokens
and_aggregate_num_emitted_tokens
metrics are non-blocking, I believe settingpin_memory
to False is a better tradeoff to significantly reduce memory usage.