-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[Misc] Improve cli help show #15455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Misc] Improve cli help show #15455
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Rather than change the platform behavior, I think a cleaner solution would be to avoid importing them too early in the first place inside |
yeah, but seems not just one
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the problem is we are importing too many things in vllm/__init__.py
, and people are used to run from vllm import LLM
.
maybe we can follow the same approach as vllm/envs.py
and vllm/platforms/__init__.py
, to introduce a module level __getattr__
for lazy import on every attribute access.
5ade301
to
fe48713
Compare
fe48713
to
7d47acc
Compare
vllm/engine/arg_utils.py
Outdated
current_platform.pre_register_and_update(parser) | ||
# Skip to avoid triggering platform detection | ||
import sys | ||
if not any(arg in sys.argv for arg in ["-h", "--help"]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can move this line to utils.py
, to avoid duplicating it. you might also want to consider -v
for showing the version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
7d47acc
to
0251745
Compare
This pull request has merge conflicts that must be resolved before it can be |
0251745
to
66785fc
Compare
Signed-off-by: reidliu41 <reid201711@gmail.com>
This pull request has merge conflicts that must be resolved before it can be |
@youkaichao hi, sorry to bother you , could you please help to take a look again? |
hi @russellb seems reviewer is quite busy, if you have time, could you please help to take a look? |
looks like #15128 might be more mature and comprehensive? |
@davidxia @reidliu41 Hi, I believe some parts of your PR are definitely necessary. That said, my own PR doesn’t fully optimize |
@davidxia yes @Chen-0210 thanks for your feedback. I think is ok. |
Seems better to show help without
the detected info
.