[rlhf] support named placement group #14410
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 engine will create the engine in a separate process, and controlling the process placement becomes complicated.
suggested by the ray team, we can use https://docs.ray.io/en/latest/ray-core/scheduling/placement-group.html#advanced-named-placement-group , and pass the ray placement group name by an env var.
however, I find the named-placement-group does not work right now. it hangs when looking up the placement group.
steps to reproduce the hang:
$ cd examples/offline_inference $ VLLM_USE_V1=1 python3 rlhf.pyit hangs when we try to get the placement group, i.e. the added line: