-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
[Kernel] Integrate DeepGEMM dense block fp8 #13996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kernel] Integrate DeepGEMM dense block fp8 #13996
Conversation
Signed-off-by: mgoin <mgoin64@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: mgoin <mgoin64@gmail.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
Curious, do we see perf wins here? |
@houseroad it seems worse at small M but better at large M compared to our CUTLASS kernels, however this is only true for specific shapes. I need to do more careful benchmarking but in the above lm-eval gsm8k throughput test it seems to be ~same |
This pull request has merge conflicts that must be resolved before it can be |
Hi, do we plan to merge this PR? We did a benchmark on 8xH200 and we saw ~5% otps gain on Deepseek-r1. Input len=1600, outputlen=600 and bs=1/4/8, tp=8. |
fi we do see perf wins, we can pick this PR up. cc: @chenyang78 |
Thanks for the heads-up. I will look into this. |
WIP since the performance is not better on my systems (8xH100 CUDA 12.5 and 8xH200 CUDA 12.4) compared to our CUTLASS kernel, and I'm unsure how we can distribute DeepGEMM. See #13917 for microbenchmarks
Setup
I installed DeepGEMM in a parallel directory to vLLM, like so
Usage
E2E evaluations/benchmarks on GSM8k with 8xH200 and CUDA 12.4:
Default (using our existing CUTLASS Block FP8):
DeepGEMM: