Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Fix the Kernels, Core, and Prefix Caching AMD CI groups #13970

Merged

Conversation

SageMoore
Copy link
Contributor

This PR just updates a few tests so that they are properly skipped on AMD. This won't get the AMD CI completely green because the Entrypoints and Engine groups will still fail, but it is a step in the right direction.

Signed-off-by: Sage Moore <sage@neuralmagic.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Feb 27, 2025
@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 27, 2025
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) February 27, 2025 17:11
@robertgshaw2-redhat robertgshaw2-redhat merged commit 38acae6 into vllm-project:main Feb 27, 2025
36 checks passed
@SageMoore SageMoore deleted the sage/misc-rocm-test-fixes branch February 27, 2025 20:51
johnnynunez pushed a commit to johnnynunez/vllm that referenced this pull request Mar 3, 2025
…project#13970)

Signed-off-by: Sage Moore <sage@neuralmagic.com>
Signed-off-by: Johnny <johnnynuca14@gmail.com>
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
Alexei-V-Ivanov-AMD added a commit to ROCm/vllm that referenced this pull request Mar 4, 2025
…ject).

Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
…project#13970)

Signed-off-by: Sage Moore <sage@neuralmagic.com>
Signed-off-by: Linkun Chen <github@lkchen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants