Skip to content

[Bugfix] Remove noisy error logging during local model loading #13458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

[Bugfix] Remove noisy error logging during local model loading #13458

merged 2 commits into from
Feb 18, 2025

Conversation

@Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Feb 18, 2025 •
edited by github-actions bot
Loading

@Isotr0py
fix error logging for list_repo_files
ba1d60a 
Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions
Copy link

github-actions bot commented Feb 18, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@Isotr0py Isotr0py changed the title [Bugfix] Fix failing local model loading [Bugfix] Fix broken local model loading Feb 18, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) February 18, 2025 05:53
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2025
ywang96
ywang96 reviewed Feb 18, 2025
View reviewed changes
@Isotr0py
remove unnecessary logger.error
c1b0615 
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py Isotr0py changed the title [Bugfix] Fix broken local model loading [Bugfix] Remove noisy error logging during local model loading Feb 18, 2025
@simon-mo simon-mo merged commit 29fc577 into vllm-project:main Feb 18, 2025
28 of 31 checks passed
@Isotr0py Isotr0py deleted the fix-local branch February 18, 2025 11:16
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 20, 2025
@Isotr0py
[Bugfix] Remove noisy error logging during local model loading (vllm-…
08f7b2f 
…project#13458)
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
@Isotr0py @Akshat-Tripathi
[Bugfix] Remove noisy error logging during local model loading (vllm-…
053e304 
…project#13458)
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Isotr0py @lulmer
[Bugfix] Remove noisy error logging during local model loading (vllm-…
d680a05 
…project#13458)

Signed-off-by: Louis Ulmer <ulmerlouis@gmail.com>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Isotr0py @shreyankg
[Bugfix] Remove noisy error logging during local model loading (vllm-…
2133b1a 
…project#13458)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywang96 ywang96 ywang96 left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees

No one assigned

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Isotr0py @DarkLight1337 @ywang96 @simon-mo