Skip to content

Conversation

@khluu
Copy link
Collaborator

@khluu khluu commented Feb 11, 2025

Try to convert as many Qwen and Qwen2 to Qwen2.5 and reduce model size as we can.

p
Signed-off-by:  <>
@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 11, 2025
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

p
Signed-off-by:  <>
@DarkLight1337
Copy link
Member

DarkLight1337 commented Feb 12, 2025

Qwen shares the same architecture with Qwen-VL so I'd like to keep at least one test to check that the text-only version works correctly (there have been regressions in the past due to updating Qwen-VL)

p
Signed-off-by:  <>
@khluu
Copy link
Collaborator Author

khluu commented Feb 12, 2025

Qwen shares the same architecture with Qwen-VL so I'd like to keep at least one test to check that the text-only version works correctly (there have been regressions in the past due to updating Qwen-VL)

okay I just reverted test_chat_echo to use Qwen2 still

@khluu khluu enabled auto-merge (squash) February 12, 2025 06:27
@DarkLight1337
Copy link
Member

DarkLight1337 commented Feb 12, 2025

Qwen shares the same architecture with Qwen-VL so I'd like to keep at least one test to check that the text-only version works correctly (there have been regressions in the past due to updating Qwen-VL)

okay I just reverted test_chat_echo to use Qwen2 still

We need to load the Qwen (V1) model specifically, at least untilr #13157 is merged - afterwards we should be free to remove the test outright.

@mergify
Copy link

mergify bot commented Feb 13, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @khluu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 13, 2025
Signed-off-by: kevin <kevin@anyscale.com>
"OrionStarAI/Orion-14B-Chat": PPTestSettings.fast(),
"adept/persimmon-8b-chat": PPTestSettings.fast(),
"microsoft/phi-2": PPTestSettings.fast(),
"Qwen/Qwen2.5-1.5B-Instruct": PPTestSettings.fast(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep this in alphabetical order (by model architecture)? Also, the test isn't actually run unless you include the model name in TEST_MODELS

"microsoft/phi-2", # phi
marks=[pytest.mark.core_model],
),
pytest.param(
Copy link
Member

@DarkLight1337 DarkLight1337 Feb 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this now that #13157 has been merged.

@mergify
Copy link

mergify bot commented Feb 18, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @khluu.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 18, 2025
@DarkLight1337
Copy link
Member

I guess this isn't necessary anymore?

@khluu
Copy link
Collaborator Author

khluu commented Feb 22, 2025

yep let me close the PR

I guess this isn't necessary anymore?

@khluu khluu closed this Feb 22, 2025
auto-merge was automatically disabled February 22, 2025 13:30

Pull request was closed

@khluu khluu deleted the khluu/consolidate_qwen branch February 26, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-merge needs-rebase ready ONLY add when PR is ready to merge/full CI is needed structured-output

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants