Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][Hardware][CPU] Fix multi_modal_kwargs broadcast for CPU tensor parallel #10541

Merged
merged 3 commits into from
Nov 23, 2024
Merged

[Bugfix][Hardware][CPU] Fix multi_modal_kwargs broadcast for CPU tensor parallel #10541

merged 3 commits into from
Nov 23, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Nov 21, 2024 •
edited by github-actions bot
Loading

  • Fix CPU tensor parallel inference on LMMs
  • multi_modal_kwargs should be broadcast to CPU worker

@Isotr0py
fix cpu tp for LMM
8b45712 
Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py changed the title [Bugfix][Hardware][CPU] Fix CPU multi_modal_kwargs broadcast for tensor parallel [Bugfix][Hardware][CPU] Fix multi_modal_kwargs broadcast for CPU tensor parallel Nov 21, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 21, 2024 17:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 21, 2024
@DarkLight1337
Copy link
Member

Thanks for fixing!

@DarkLight1337
Copy link
Member

#10581 should fix the CI failure, please merge from main again.

@youkaichao youkaichao disabled auto-merge November 23, 2024 05:25
@youkaichao youkaichao merged commit 4cfe5d2 into vllm-project:main Nov 23, 2024
45 of 47 checks passed
@Isotr0py Isotr0py deleted the fix-cpu-mm-tp branch November 23, 2024 06:08
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
@Isotr0py @mfournioux
[Bugfix] multi_modal_kwargs broadcast for CPU tensor parallel (vllm…
cbf06f7 
…-project#10541)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@Isotr0py
[Bugfix] multi_modal_kwargs broadcast for CPU tensor parallel (vllm…
f10ea78 
…-project#10541)

Signed-off-by: Isotr0py <2037008807@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isotr0py @DarkLight1337 @youkaichao